Hi All,
I've been working on cleaning up the watched/unwatched stuff from the video library (essentially removing the button, though I haven't got that far quite yet) and have been adding smartplaylists for all types of video (episodes, shows, musicvideos + movies).
I'm at the point now where I need to do polish work and identify what works and what doesn't, and what can be done to make it better. In addition, I'm also after suggestions for how to make the UI for the whole videolibrary work more cohesively, though that will be done after the cleanup work is complete and it hits SVN trunk.
I'm thus after some beta testers to have a go with it and let me know what works, what doesn't, what needs improvement and so on.
Requirements are:
1. You need to be willing to test lots of different things, even if they don't interest you, essentially trying to break things as well as making sure *everything* is tested.
2. You need to be able to re-test within 24 hours of the fix being made.
3. If you break things, you need to be able to reproduce it and tell me how so that I can reproduce it.
4. You need to at least be able to run the win32 (directx) build of XBMC on your PC. Ideally, you need to be able to checkout and build from SVN as well, though I may be willing to supply builds if I don't get enough testers with this ability.
If you meet the above requirements and are willing to help me out, please let me know either by replying to this thread, or by PM'ing me.
For those of you not willing to commit to beta testing but want to try it out, you can check it out from SVN using this URL:
http://xbmc.svn.sourceforge.net/svnroot/xbmc/branches/watched
Thanks
Jonathan
The code for this is now in SVN, revision 13219.
You all now have no excuses whatsoever to test it all out and let me know what works, what doesn't, and what could be done better.
Cheers,
Jonathan
I've uploaded three more patches to SourceForge, with explanations of the problems they fix. :)
There's also a problem that you can't sort for example musicvideo-smartplaylists by artist. The query ends with "ORDER BY never_use_this". I think this also applies to other fields and the other smartplaylist-types. I didn't bother making a patch for this since I'm not sure what you're supposed to be able to order by, but I think you should be able to order by artist in musicvideolists. Right now you can choose to order for example movielists by fields that only apply to songs-/albumlists when you use the gui to create a smartplaylist. Maybe you should change all the "never_use_this", so we can order by any valid field? cubicgarden.com::
2 for quite sometime now, but recently with the Firefox 1.5 beta publicly out and I was unimpressed with the unknown protocal used for video and audio.
http://www.cubicgarden.com/blojsom/blog/cubicgarden/technology/computing/2005/HOME |
It's all in SVN (trunk + linuxport) so you can test away as and when you want.
Great - I shall look at the submitted patches and get them in. Thanks alot!
I was a little worried with musicvids, as it was the one section I didn't test well (due to not having enough dummy files :)
You can already use smartplaylists as a rule (to nest playlists) or at least you are supposed to be able to :)
Todos would involve listing only the relevant smartplaylists (such as tvshows + episodes) at certain levels in the hierachy if one wants and so on (helps also with the smartplaylist nesting). Something like smartplaylists://tvshows or something for the URL may be possible perhaps.
Cheers,
Jonathan
Order will be affected by the sort order within the window you are in. Set the sort order to "Playlist" to use whatever you specified within the playlist.
Cheers,
Jonathan
Actors are not listed alphabetically (making it a real PITA to find one)
If you start by naming your smart playlist, you will still get the name dialog when you want to save it.
Your favorite iTunes smart playlists - The Unofficial Apple Weblog (TUAW)::
But I wanted to hear my favorites and E Inks AM300 developers kit gets shown off on video Microsoft details pre-beta release of Windows 7. AOL News
http://www.tuaw.com/2005/06/08/your-favorite-itunes-smart-playlists/#commentsHOME |
Sort by episode title will sort by s0x.e0y.epname. (by design?)
So will sort by TV Show
My description may not be the best of the browse, please try it out to see what exactly I mean. (should be pretty apparent once you try)
The order clause in the playlist is supposed to fill the playlist sort order field, which it appears has been left out. EDIT: Taken care of.
Wanted: Beta testers for video smartplaylists - XBMC Community Forum::
Wanted: Beta testers for video smartplaylists XBMC General Discussion and Announcements Wanted: Beta testers for video smartplaylists. User Name. Remember
http://xbmc.org/forum/showthread.php?p=180406#post180406HOME |
The name dialog when you save it is intentional - it allows you to name it differently than what you save it as, should you want to.
If anyone can supply me with a Win32 SDL build with the capability I am willing to test.
(Exe should be enough?)
I have never been able to run the Direct X build on my PC.
Bug for both music and video smart playlists.
When you browse for a playlist to include / exclude, you have to select and open a playlist and then go back via ".." before you are allowed to choose a playlist (ie the OK button does not get selectable before you go through this ceremony).
Also the Browse button is not highlighted (active) when Playlist is the argument, you can get around it by clicking the text field. (Neither does it for Title, by design or not?)
kraqh3d: Yes, that's the idea. A new content type will be used in the set content dialog, but I'm not sure we need to push it all the way through (basically we don't want to be doing a whole bunch of "if (strContent.Equals("adult") strContent.Equals("video"))" stuff if we can avoid it, though ofcourse a function could always be added to wrap that up (eg info.IsMovie()). I suspect that would be the easiest way to get things done, but I don't think we want to duplicate the tables in the db - perhaps we could have a separate view though?
sho: The idea with playlist was it only made sense to allow them to choose one (i.e. instead of typing in the name), but yes, this is somewhat inconsistent now that we have the browse button (we didn't always). Not sure how the filebrowser dialog is working on that front, but it sounds like there's some issue there as well? We may be able to do it just via the select dialog in the future.
Cheers,
Jonathan
I've been testing it, and found some typos that broke some of the smartplaylist rules and the libraryviews for musicvideos. Patches are submitted to SourceForge, and I might submit another one for using smartplaylists as a rule in a few days. ;)
Great work by the way, :) and from what I can tell it must have been a lot of work! :eek2: It's cool that I can now make smartplaylists to sort my movies and I'm looking forward to having playcount on musicvideos. :nod:
re: the adult stuff ... why not both a flag in the database, and a new content type? by making it a new content type, the scrapers can also be hidden.
sho, can you provide an example video smartplaylist that produces output with duplicate genres?
I only see Mvids as an option in 13239 .
Then I presume it was merged later?
re: the adult stuff ... why not both a flag in the database, and a new content type? by making it a new content type, the scrapers can also be hidden.
And a new XBMC-wide flag that can enable/disable all adult-related content.
The only adult content I need to filter-out are the adult movie scrapers (which I currently do by deleting all by IMDB and the TV scrapers), but figure a profile-wide setting would be useful, from what I've read.
I'm on it - the reason is due to the watched/unwatched filtering stuff. We currently supply dupes to the mediawindow which filters them out according to the user's preference. So to reproduce, just have some movies watched and some unwatched in a particular genre, then browse from a genre rule.
It'll be fixed once we resolve what we're doing with the library queries. The current plan is to:
1. Remove the path locking stuff.
2. Add an "adult" flag to handle what 1 was doing (how much we allow for separate content types is still up in the air - i.e. should it be a separate strContent for scraping, or just a flag?)
3. Redo the non-title queries to handle the playcount and adult flag at the query level (i.e. setting m_playCount appropriately on the item) rather than filtering at the window level.
If you want to take on any of this let me know :)
Cheers,
Jonathan
Thanks all for the fantastic feedback.
It is no wonder XBMC is as great as it is when we get this sort of superb support from the community.
Unfortunately due to the overwhelming number of replies, I haven't been able to get anything done as I've been rushed off my feet replying to everyone.
(Note: For the humour impaired, the above is known as sarcasm).
And ya'll wonder why we have a resident Grumpy Bastard Developer...
Cheers,
Jonathan
Probably because I didn't test it :p
Will add to my list. Thanks for testing :)
I found out it is somehow bound to my db (something to do with watched / unwatched)
JM is much better equipped to answer this though ;)
Edit.. I see we were posting at the same time. :)
Of course... cheers.
It looks like all the important issues I brought up have been addressed.
Except mabe the sorting order of browseable items (actors, directors, genre etc.)
For me all movie genres and some actors are duplicated when browsed, but not in the movie nodes. Any idea what gives?
(The same are not duplicated when I check the db in SQLiteSpy)
Cool, maybe both filename and playlist name should be shown on the edit smart playlist dialog?
Also I can't seem to be able to have order ascending / descending work as I'd expect, but maybe it will be fixed in your order changes.
right. if "hide adult content" is enabled in settings, then the scrapers and the content they've previously found can both be hidden.
I never replied as I've never complied under win32 and run exclusively under Linux. I'll see about compiling on win32 to give you some help out once i get a chance this week
Yes, agreed that the playlist selection is not obvious. You have to go in and out for the OK button to highlight - probably something to do with having files acting as folders (the playlists).
I think it'll be better to just retrieve the folder list and display it using the select dialog as is done for everything else. Gives consistency all around that way.
Cheers,
Jonathan
 Where was the last debate on wednesday with Mccain and Obama?
 INSTANCE / WAITING FOR SPRING
|
Wanted: Beta testers for video smartplaylists